Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test where filter handling numeric property values #7821

Merged
merged 3 commits into from Feb 4, 2020
Merged

Test where filter handling numeric property values #7821

merged 3 commits into from Feb 4, 2020

Conversation

ashmaroli
Copy link
Member

@ashmaroli ashmaroli commented Sep 19, 2019 •
edited

Context

Closes #7820

@ashmaroli ashmaroli added the fix label Sep 19, 2019
@ashmaroli ashmaroli added this to the 4.1 milestone Sep 19, 2019
@DirtyF DirtyF requested a review from a team November 5, 2019 17:54
@DirtyF
Copy link
Member

DirtyF commented Nov 5, 2019 •
edited

@mattr- Do you mind shipping this fix in a 4.0.1?

@ashmaroli
Copy link
Member Author

Before we ship this, I would like to know if merging #7878 would fix #7820 as well. If it does, then this PR need not be merged..

@thisisdano thisisdano mentioned this pull request Nov 13, 2019
Merged
@ashmaroli ashmaroli added tests and removed fix labels Feb 3, 2020
@ashmaroli ashmaroli changed the title Fix where filter to handle numeric property values Test where filter handling numeric property values Feb 3, 2020
@ashmaroli
Copy link
Member Author

Since #7820 has been resolved on master (via #7878), this has been refactored to augment the test-suite.

@DirtyF
Copy link
Member

DirtyF commented Feb 4, 2020

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit 5cc78db into jekyll:master Feb 4, 2020
jekyllbot added a commit that referenced this pull request Feb 4, 2020
@jekyllbot
Update history to reflect merge of #7821 [ci skip]
2c04ddc
@ashmaroli ashmaroli deleted the filter-where-numerical-property branch February 5, 2020 07:07
@jekyll jekyll locked and limited conversation to collaborators Feb 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DirtyF DirtyF DirtyF approved these changes

Assignees
No one assigned
Labels
fix frozen-due-to-age internal tests
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.

"where" filter doesn't appear to accept integer values in 4.0
3 participants
@ashmaroli @DirtyF @jekyllbot