Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make number_of_words respect CJK characters #7813

Merged
merged 15 commits into from May 22, 2020
Merged

Make number_of_words respect CJK characters #7813

merged 15 commits into from May 22, 2020

Commits on Sep 5, 2019

  1. Make number_of_words respect CJK characters 

    CJK languages generally consider every single character a word.
This commit changed Liquid filter "number_of_words"
so it counts CJK characters correctly.
    @iBug
    iBug committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    afbee53 View commit details
    Browse the repository at this point in the history

  2. Maybe use lowercase for that variable?

    @iBug
    iBug committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    3cc01b1 View commit details
    Browse the repository at this point in the history

  3. RuboCop is hard to satisfy...

    @iBug
    iBug committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    1d37203 View commit details
    Browse the repository at this point in the history

  4. Use exclamation marks for %r!regex! to make RuboCop happy 

    Co-Authored-By: Matt Rogers <mattr-@github.com>
    @iBug @mattr-
    iBug and mattr- committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    6a33254 View commit details
    Browse the repository at this point in the history

  5. Update documentation to reflect changes

    @iBug
    iBug committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    1a6af42 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2020

  1. Add test for patched number_of_words filter

    @iBug
    iBug committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    360ecda View commit details
    Browse the repository at this point in the history

Commits on May 21, 2020

  1. Fix according to ashmaroli's suggestions 

    - Split with CJK characters only when present
- Avoid bloating from String#gub by using String#split with regex directly
    @iBug
    iBug committed May 21, 2020
    Configuration menu
    Copy the full SHA
    28da2dc View commit details
    Browse the repository at this point in the history

  2. Using single-character regexes without repetition is errorneous

    @iBug
    iBug committed May 21, 2020
    Configuration menu
    Copy the full SHA
    9c46861 View commit details
    Browse the repository at this point in the history

  3. Bundle exec rake test passing

    @iBug
    iBug committed May 21, 2020
    Configuration menu
    Copy the full SHA
    d0ba979 View commit details
    Browse the repository at this point in the history

  4. Merge master and fix RuboCop

    @iBug
    iBug committed May 21, 2020
    Configuration menu
    Copy the full SHA
    2f60cab View commit details
    Browse the repository at this point in the history

Commits on May 22, 2020

  1. Make CJK processing optional, adapt tests

    @iBug
    iBug committed May 22, 2020
    Configuration menu
    Copy the full SHA
    21bf5a5 View commit details
    Browse the repository at this point in the history

  2. Support auto mode, add Japanese and Korean test cases

    @iBug
    iBug committed May 22, 2020
    Configuration menu
    Copy the full SHA
    36fe3da View commit details
    Browse the repository at this point in the history

  3. Update documentation to reflect #7813

    @iBug
    iBug committed May 22, 2020
    Configuration menu
    Copy the full SHA
    758949b View commit details
    Browse the repository at this point in the history

  4. Improve documentation of the change

    @ashmaroli
    ashmaroli committed May 22, 2020
    Configuration menu
    Copy the full SHA
    676dd86 View commit details
    Browse the repository at this point in the history

  5. Reduce duplication in filter

    @ashmaroli
    ashmaroli committed May 22, 2020
    Configuration menu
    Copy the full SHA
    25d1388 View commit details
    Browse the repository at this point in the history