serve: add support for ECC certificates #7768
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is
either a 🐛 bug fix oran 🙋 enhancement.Summary
Jekyll, currently does not accept an ECC (Elliptic-Curve) private key via its
--ssl-key
option when running theserve
command, because the key loading code only assumes an RSA key with no other key types considered. Even though, even the older OpenSSL 1.0.2 supports EC keys. It means that Jekyll will fail to start with this error when an EC key is provided:This patch will try to load the provided key file as an ECC key if loading it as an RSA key failed. It also checks if the ECC key load method exists, as some Ruby variants (JRuby?) may not have it.
[ My Ruby is very rudimentary, so any suggestion for improvement is welcome. ]
Context
Jekyll server.
Test files
Script to generate a self-signed ECC certificate,
mk-ec-test.sh
:Certificate,
test-ec.crt
:Private key,
test-ec-private.pem
:Test command: