Remove patch to modify config for kramdown #7699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashmaroli
added
experimental
|
This provides some significant relief from memory allocations as well (I'm not sure if that is a good sign..): Profiler summary--- master branch https://travis-ci.org/jekyll/jekyll/jobs/541828395
+++ PR branch https://travis-ci.org/jekyll/jekyll/jobs/542345579
- Total allocated: 548.75 MB (4762592 objects)
- Total retained: 18.28 MB (95954 objects)
+ Total allocated: 539.69 MB (4742137 objects)
+ Total retained: 18.28 MB (95949 objects) |
ashmaroli
removed
do-not-review
experimental
DirtyF
approved these changes
Jun 7, 2019
mattr-
approved these changes
Jun 14, 2019
|
@parkr Would love to have your 👀 on this before merging.. |
|
@jekyllbot: merge +major |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
kramdown expects to get an
optionshash with Symbol keys. But it is not really necessary becausekramdownconverts string keys as well.Context
Resolves #6558