Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile allocations from a build session #7646

Merged
merged 2 commits into from
May 15, 2019

Conversation

ashmaroli
Copy link
Member

@ashmaroli ashmaroli commented May 5, 2019

Summary

Rake task and shell script to provide additional information for pull requests concerned with refactoring / optimizing memory allocation existing code in Core.

Notes

  • Currently, the task is wired to run with CI build's branch only. To compare 2 branches, run script/memprof locally and compare. ( TODO: Automate with an app.. 馃 )

Context

Would help with demonstrating benefits from #7641 #7643 #7653 #7654

@ashmaroli ashmaroli requested a review from a team May 10, 2019 14:28
@ashmaroli
Copy link
Member Author

@mattr- May I request this be reviewed and merged before any other optimization PR so that we can gauge the current impact of those proposed changes...

@mattr-
Copy link
Member

mattr- commented May 15, 2019

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit af055b9 into jekyll:master May 15, 2019
@jekyllbot jekyllbot added the fix label May 15, 2019
jekyllbot added a commit that referenced this pull request May 15, 2019
@ashmaroli ashmaroli deleted the memory-profiler-task branch May 15, 2019 19:13
@jekyll jekyll locked and limited conversation to collaborators May 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants