New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compute time zones on all platforms with tzinfo
gem
#7551
Conversation
This comment has been minimized.
This comment has been minimized.
* Add tzinfo-data as dependency * Add tzinfo 1.x as dependency Since 'activesupport' gem currently locks to tzinfo-1.x, we're locking to that as well to avoid conflicts with plugins that use ActiveSupport
tzinfo
gem
Does this do anything to resolve #5963? |
@mattr- Honestly, I did not even realize that a similar issue was previously reported. The current pull request is a direct reaction to the failing cucumber test in 4e68111 in this pull request. I'll try and test further to check if this issue is a regression due to cf5c689 shipped in Jekyll-3.7.1 |
The ENV["TZ"] *ought to* be correctly set during the course of a `jekyll build` session
@mattr- From my investigation, the inference is that #5963 was resolved by #6697. Disclaimer: I'm not currently sure if the tests here will fail when changes due to DST kick in.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get the conflicts resolved and CI passing so this can be merged.
What will it take to move this PR forward and get it merged (besides the obvious of fixing the merge conflicts)? It's been over a year since the PR was submitted and about 6 months since the changes in the PR were approved. |
@scottdorman Sorry for the delay, but technically, we're sort of at a stalemate here. And then there's the issue with dependencies.. The current timezone management in Jekyll requires the gem So in other words, its a messy situation.. |
@ashmaroli Thanks for the update. On the surface, it seems like such a simple thing to fix. :) It seems like doing something around using UTC dates here would be the solution, or at least part of the solution, since that should remove the issues around DST changes. |
Summary
Calculate Time Zone with
tzinfo
library on all platformstzinfo 1.x
as a runtime_dependency of JekyllThe revert is because
activesupport
gem currently locks totzinfo 1.x
. Even though Jekyll has no direct dependency onactivesupport
, there may be plugins out there that depend on a recent version ofActiveSupport
.Utils::WinTZ
module asUtils::TimeZone
Context
Resolves #7550