Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: jekyll doctor should check for drafts outside custom collections directory #6986

Closed
wants to merge 4 commits into from
Closed

WIP: jekyll doctor should check for drafts outside custom collections directory #6986

wants to merge 4 commits into from

Conversation

localheinz
Copy link
Contributor

This PR

  • adjusts the doctor command to check for drafts outside the custom collections directory

Follows #6985 (comment).

@localheinz localheinz force-pushed the feature/drafts-with-custom-collection-directory branch from 4ca88b8 to 9992e80 Compare May 4, 2018 14:53
@localheinz localheinz force-pushed the feature/drafts-with-custom-collection-directory branch from 9992e80 to a4e9ab7 Compare May 4, 2018 14:59
@localheinz localheinz mentioned this pull request May 4, 2018
Merged
1 task
@pathawks pathawks changed the title Enhancement: Adjust doctor command to check for drafts outside custom collections directory jekyll doctor should check for drafts outside custom collections directory May 4, 2018
@pathawks pathawks requested a review from a team May 4, 2018 15:24
@ashmaroli ashmaroli force-pushed the feature/drafts-with-custom-collection-directory branch from a4e9ab7 to ae63051 Compare May 4, 2018 16:18
@ashmaroli
Copy link
Member

@localheinz

  • Git commit messages are best kept short (less than 50 characters). Please avoid unnecessary identifiers such as Fix:, Enhancement:, etc in the commit messages and PR titles. (I've adjusted the message to demonstrate.)
  • private methods should be defined after all the public methods in a class. (I've moved the #inside_custom_collections_dir? method for you to demonstrate.)

ashmaroli
ashmaroli requested changes May 4, 2018
View reviewed changes
lib/jekyll/commands/doctor.rb Outdated Show resolved Hide resolved
@ashmaroli
Copy link
Member

@localheinz Will you be able to write a Cucumber test for this?

@localheinz
Copy link
Contributor Author

@ashmaroli

I’ll try! 👍

@ashmaroli ashmaroli changed the title jekyll doctor should check for drafts outside custom collections directory WIP: jekyll doctor should check for drafts outside custom collections directory Jul 10, 2018
@localheinz localheinz closed this Jan 24, 2021
@localheinz localheinz deleted the feature/drafts-with-custom-collection-directory branch January 24, 2021 17:26
@jekyll jekyll locked and limited conversation to collaborators Jan 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ashmaroli ashmaroli ashmaroli requested changes

Assignees
No one assigned
Labels
enhancement frozen-due-to-age needs-tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@localheinz @ashmaroli @DirtyF @pathawks @jekyllbot