Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft a release post for v3.7.3 #6803

Merged
merged 2 commits into from Feb 25, 2018
Merged

Conversation

ashmaroli
Copy link
Member

@ashmaroli ashmaroli commented Feb 25, 2018

Release post for a patch release that fixes a bug introduced in v3.7.0
(Other bug-fixes should be released as part of v3.8.0 IMHO)

Requirements:


Hello Jekyllers!! :wave:
We're pleased to announce the release of `v3.7.3` which fixes a bug one might encounter while using `Jekyll - 3.7.x` along with a
jekyll plugin that in turn uses the `I18n` library.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

capitalize Jekyll here


When [v3.7.0]({% link _posts/2018-01-02-jekyll-3-7-0-released.md %}) enhanced our `slugify` filter with a `latin` option, we also
hardcoded a default fallback locale for the `I18n` library to avoid an exception raised in the event the library fails to find
any locale. This led to issues with third-party i18n plugins for Jekyll especially since default locale that got assigned before
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comma before especially

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the default locale

When [v3.7.0]({% link _posts/2018-01-02-jekyll-3-7-0-released.md %}) enhanced our `slugify` filter with a `latin` option, we also
hardcoded a default fallback locale for the `I18n` library to avoid an exception raised in the event the library fails to find
any locale. This led to issues with third-party i18n plugins for Jekyll especially since default locale that got assigned before
the plugin was loaded, and irrespective of whether the `slugify` filter was used.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove and here

@ghost
Copy link

ghost commented Feb 25, 2018

Backported #6791 to https://github.com/jekyll/jekyll/tree/3.7-stable

@ghost
Copy link

ghost commented Feb 25, 2018

Going to release the gem and then merge this 🎉

@ashmaroli
Copy link
Member Author

Going to release the gem

I'm game as long as @pathawks is fine with this too..

@pathawks
Copy link
Member

Thanks for your work on this, @ashmaroli

@ghost
Copy link

ghost commented Feb 25, 2018

@jekyllbot: merge +docs

@jekyllbot jekyllbot merged commit 12cbe54 into jekyll:master Feb 25, 2018
jekyllbot added a commit that referenced this pull request Feb 25, 2018
@ashmaroli ashmaroli deleted the release-post-373 branch February 25, 2018 17:01
@jekyll jekyll locked and limited conversation to collaborators Jul 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants