Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix timezone incosistencies between different ruby version #6697

Merged
merged 6 commits into from Jan 25, 2018
Merged

Fix timezone incosistencies between different ruby version #6697

merged 6 commits into from Jan 25, 2018

Commits on Jan 11, 2018

  1. add failing tests for #5963 

    it fails with ruby 2.4 onwards and passes up to ruby 2.3
    @Crunch09
    Crunch09 committed Jan 11, 2018
    2
    Copy the full SHA
    eaac869 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2018

  1. make sure timezone is rolled back after test ran

    @Crunch09
    Crunch09 committed Jan 16, 2018
    Copy the full SHA
    ac021ac View commit details
    Browse the repository at this point in the history

  2. date should be a date, not a string 

    In a real application this would have already been read as a date so
make sure our scenario replicates that behaviour.
    @Crunch09
    Crunch09 committed Jan 16, 2018
    Copy the full SHA
    5365355 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2018

  1. fix rubocop offenses

    @Crunch09
    Crunch09 committed Jan 17, 2018
    Copy the full SHA
    2130da7 View commit details
    Browse the repository at this point in the history

  2. always convert date to localtime as set by ENV['TZ'] 

    This makes sure we don't have inconsistencies between different ruby
versions.
    @Crunch09
    Crunch09 committed Jan 17, 2018
    Copy the full SHA
    84a1ae2 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2018

  1. make sure timezone setting is applied before reading post 

    In a real world example the post frontmatter would only be read during
the build step after the configuration has already been applied. In a
cucumber scenario though the frontmatter is read outside of any
configuration so in this case the `timezone` setting of `UTC` wasn't applied.
    @Crunch09
    Crunch09 committed Jan 20, 2018
    Copy the full SHA
    e3b32f3 View commit details
    Browse the repository at this point in the history