Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update installation.md #6694

Merged
merged 2 commits into from Jan 20, 2018
Merged

Update installation.md #6694

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81bd098
Update installation.md
sashabrava Jan 13, 2018
e2572f8
Correcting grammar mistake
sashabrava Jan 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/_docs/installation.md
View file
Open in desktop
Expand Up @@ -15,9 +15,9 @@ Before you start, make sure your system has the following:

- GNU/Linux, Unix, or macOS
- [Ruby](https://www.ruby-lang.org/en/downloads/) version 2.2.5 or above, including all development
headers
- [RubyGems](https://rubygems.org/pages/download)
- [GCC](https://gcc.gnu.org/install/) and [Make](https://www.gnu.org/software/make/) (in case your system doesn't have them installed, which you can check by running `gcc -v` and `make -v` in your system's command line interface)
headers (ruby installation can check by running `ruby -v`, development headers can be checked on Ubuntu by running `apt list --installed ruby-dev`)
Copy link
Member

@ashmaroli ashmaroli Jan 14, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

- (ruby installation can check by running `ruby -v`,
+ (ruby installation can be checked by running `ruby -v`,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it is better to make a Passive voice - "(ruby installation can be checked by running ruby -v"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

of course.. I meant to type (ruby installation can be checked by running ruby -v itself 😆 🤦‍♂️

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! 👍

- [RubyGems](https://rubygems.org/pages/download) (which you can check by running `gem -v`)
- [GCC](https://gcc.gnu.org/install/) and [Make](https://www.gnu.org/software/make/) (in case your system doesn't have them installed, which you can check by running `gcc -v`,`g++ -v` and `make -v` in your system's command line interface)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is g++ necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, otherwise I catch following error:
jekyll


<div class="note info">
<h5>Problems installing Jekyll?</h5>
Expand Down