New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Add note about posts in context of collections_dir #6680
Fix: Add note about posts in context of collections_dir #6680
Conversation
6764d0e
to
78d9d02
Compare
docs/_docs/collections.md
Outdated
|
||
<p>Then Jekyll will look in <code>my_collections/_books</code> for the <code>books</code> collection, and | ||
in <code>my_collections/_recipes</code> for the <code>recipes</code> collection.</p> | ||
in <code>my_collections/_recipes</code> for the <code>recipes</code> collection. Since posts and drafts are collections as well, you will need to move the <code>_drafts</code> and <code>_posts</code> directories into <code>my_collections</code> as well.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we turn this into a warning?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
drafts are not a collection! They're just a temporary holding..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated my previous PR to confirm that drafts at the root are processed even when a custom collections_dir is set..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about the issue, though, that when you have collections in a custom collections directory and posts at the root, that the posts will have a draft status (regardless of whether publishing date is in the past or not)?
Ha, never mind.
docs/_docs/collections.md
Outdated
|
||
<p>Then Jekyll will look in <code>my_collections/_books</code> for the <code>books</code> collection, and | ||
in <code>my_collections/_recipes</code> for the <code>recipes</code> collection.</p> | ||
in <code>my_collections/_recipes</code> for the <code>recipes</code> collection. Since posts and drafts are collections as well, you will need to move the <code>_drafts</code> and <code>_posts</code> directories into <code>my_collections</code> as well.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
drafts are not a collection! They're just a temporary holding..
78d9d02
to
d1e88f0
Compare
9e609f4
to
a73793f
Compare
docs/_docs/collections.md
Outdated
<h5>Be sure to move posts into custom collections directory</h5> | ||
|
||
<p>If you specify a directory to store all your collections in the same place with <code>collections_dir: my_collections</code>, then you will need to move your <code>_posts</code> directory to <code>my_collections/_post</code>.</p> | ||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small typo..
- you will need to move your <code>_posts</code> directory to <code>my_collections/_post</code>.
+ you will need to move your <code>_posts</code> directory to <code>my_collections/_posts</code>.
63180b1
to
6793402
Compare
Already done! |
/cc @jekyll/documentation |
Please unsubscribe the email for the above account. |
Thanks @localheinz, this should save some headache to many people 😓 @jekyllbot: merge +docs |
Thank you, @ashmaroli, @DirtyF, and of course, @jekyllbot! |
This PR
_posts
directory in the context of specifying a customcollections_dir
Follows #6331.
Related to #6678.
Follows #6679 (comment).