New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Test against Ruby 2.5.0 #6664
Conversation
jekyllbot
commented
Jan 3, 2018
•
edited by DirtyF
edited by DirtyF
- Test against Ruby 2.5.0
- Stop testing against Ruby 2.1 (EOL)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might as well bump all ruby versions in the matrix..
.travis.yml
Outdated
- &ruby1 2.5.0 | ||
- &ruby2 2.4.2 | ||
- &ruby4 2.3.5 | ||
- &ruby4 2.2.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
duplicate assignment:
&ruby4 2.3.5
&ruby4 2.2.8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!!
We test Rouge 1.11 twice. Can you please remove the one which specifies the TEST_SUITE and just leave the second one?
4e219d2
to
e3375eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JRuby is now at 9.1.15.0
..
And looks like we'll have to drop Cucumber tests for Ruby 2.1 to have Travis go Green again..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It’s fully duplicate so you can remove that part of the matrix entirely.
.travis.yml
Outdated
- &jruby jruby-9.1.14.0 | ||
|
||
matrix: | ||
include: | ||
- rvm: *ruby1 | ||
env: TEST_SUITE=test ROUGE=1.11.1 | ||
env: TEST_SUITE=test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just remove this section entirely including rvm above.
e3375eb
to
72059d1
Compare
Travis is green again 💚 |
@DirtyF out of curiosity, why did you remove the more specific versions? Using the most up-to-date versions seems like a good idea? |
@parkr I don't remember CI failing because of an updated patched version of Ruby, added the specificity back with latest versions, travis is still green 💚 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🆕
I guess we also need to remove 2.1 on AppVeyor? |
Or we set jekyll-watch to 1.x when Ruby 2.1 or below! |
We haven't received any complaints of recent releases of So, lets drop testing on Ruby 2.1 its EOL anyways.. |
👍 to dropping a potentially unsafe version of Ruby. Can happen in another PR. |
#6560 drops support of Ruby 2.1 and 2.2 |
#6640 adds dependency update checks to jekyll doctor. I don’t see a PR which removes 2.1. You can add it here too. |
I think you pointed towards the wrong PR.. Either ways, existing PRs propose dropping library support for older Rubies entirely.. I was suggesting just stop testing on outdated Ruby versions.. |
I meant #6560 |
please drop 2.1 on AppVeyor too.. |
- Test against latest patched versions - Remove duplicate Rouge 1.x testing - Stop testing EOL Ruby 2.1
80a84e2
to
3f151a2
Compare
Definitely remove Ruby 2.1, but 2.2 is still in security maintenance. https://www.ruby-lang.org/en/downloads/branches/ Let’s remove 2.1 in this PR. |
Feel free to merge once Travis & AppVeyor are both 💚 |
@jekyllbot: merge +dev |