return correct file in dir if dir has same name as file #6569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- bar.html - bar |- baz.html _GET /bar/_ _Before:_ Returns bar.html _After:_ Returns bar.html _GET /bar/baz_ _Before:_ Returns bar.html _After:_ Returns bar/baz.html _GET /bar/whatever_ _Before:_ Returns bar.html _After:_ Returns 404 This fixes jekyll#6475
|
@ashmaroli Yes, this is checked by this test. |
|
Have you verified this against GitHub Pages? Ideally we'd keep this server behaviour the same, especially around an edge case like this which is confusing to users. |
|
@parkr Checked the current Github-Pages behavior with https://janpio.github.io/jekyll-path-test/ (provided by @janpio ). After this PR, webrick should have the same behavior. |
ghost
approved these changes
Nov 23, 2017
parkr
approved these changes
Nov 24, 2017
|
@jekyllbot: merge +bug |
jekyllbot
added a commit
that referenced
this pull request
Nov 24, 2017
DirtyF
pushed a commit
that referenced
this pull request
Dec 7, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
|- baz.html
GET /bar/
Before: Returns bar.html
After: Returns bar.html
GET /bar/baz
Before: Returns bar.html
After: Returns bar/baz.html
GET /bar/whatever
Before: Returns bar.html
After: Returns 404
This fixes #6475. Thanks @janpio for the great reproduction script! 馃憤
cc: @jekyll/build