Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport pull/rubocop from #6444 to 3.6-stable #6450

Merged
merged 1 commit into from Oct 20, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 1 addition & 3 deletions .rubocop.yml
@@ -1,6 +1,6 @@
---
AllCops:
TargetRubyVersion: 2.0
TargetRubyVersion: 2.1
Include:
- lib/**/*.rb
Exclude:
Expand Down Expand Up @@ -117,8 +117,6 @@ Style/Documentation:
- !ruby/regexp /features\/.*.rb$/
Style/DoubleNegation:
Enabled: false
Style/Encoding:
EnforcedStyle: when_needed
Style/GuardClause:
Enabled: false
Style/HashSyntax:
Expand Down
2 changes: 1 addition & 1 deletion Gemfile
Expand Up @@ -30,7 +30,7 @@ group :test do
gem "nokogiri", RUBY_VERSION >= "2.2" ? "~> 1.7" : "~> 1.7.0"
gem "rspec"
gem "rspec-mocks"
gem "rubocop", "~> 0.50.0"
gem "rubocop", "~> 0.51.0"
gem "test-dependency-theme", :path => File.expand_path("test/fixtures/test-dependency-theme", __dir__)
gem "test-theme", :path => File.expand_path("test/fixtures/test-theme", __dir__)

Expand Down
6 changes: 3 additions & 3 deletions features/step_definitions.rb
Expand Up @@ -156,7 +156,7 @@
When(%r!^I run jekyll(.*)$!) do |args|
run_jekyll(args)
if args.include?("--verbose") || ENV["DEBUG"]
$stderr.puts "\n#{jekyll_run_output}\n"
warn "\n#{jekyll_run_output}\n"
end
end

Expand All @@ -165,7 +165,7 @@
When(%r!^I run bundle(.*)$!) do |args|
run_bundle(args)
if args.include?("--verbose") || ENV["DEBUG"]
$stderr.puts "\n#{jekyll_run_output}\n"
warn "\n#{jekyll_run_output}\n"
end
end

Expand All @@ -174,7 +174,7 @@
When(%r!^I run gem(.*)$!) do |args|
run_rubygem(args)
if args.include?("--verbose") || ENV["DEBUG"]
$stderr.puts "\n#{jekyll_run_output}\n"
warn "\n#{jekyll_run_output}\n"
end
end

Expand Down
2 changes: 1 addition & 1 deletion lib/jekyll/commands/build.rb
Expand Up @@ -96,7 +96,7 @@ def watch(site, options)
)
end
end
end # end of class << self
end
end
end
end
2 changes: 1 addition & 1 deletion lib/jekyll/configuration.rb
Expand Up @@ -206,7 +206,7 @@ def read_config_files(files)
rescue ArgumentError => err
Jekyll.logger.warn "WARNING:", "Error reading configuration. " \
"Using defaults (and options)."
$stderr.puts err
warn err
end

configuration.fix_common_issues.backwards_compatibilize.add_default_collections
Expand Down
2 changes: 1 addition & 1 deletion lib/jekyll/converters/markdown/redcarpet_parser.rb
Expand Up @@ -47,7 +47,7 @@ def block_code(code, lang)
end

module WithRouge
def block_code(code, lang)
def block_code(_code, lang)
code = "<pre>#{super}</pre>"

"<div class=\"highlight\">#{add_code_tags(code, lang)}</div>"
Expand Down
1 change: 0 additions & 1 deletion test/test_filters.rb
@@ -1,4 +1,3 @@
# coding: utf-8
# frozen_string_literal: true

require "helper"
Expand Down
1 change: 0 additions & 1 deletion test/test_kramdown.rb
@@ -1,4 +1,3 @@
# encoding: UTF-8
# frozen_string_literal: true

require "helper"
Expand Down
1 change: 0 additions & 1 deletion test/test_tags.rb
@@ -1,4 +1,3 @@
# coding: utf-8
# frozen_string_literal: true

require "helper"
Expand Down
1 change: 0 additions & 1 deletion test/test_utils.rb
@@ -1,4 +1,3 @@
# encoding: utf-8
# frozen_string_literal: true

require "helper"
Expand Down