Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alias Drop#invoke_drop to Drop#[] #6338

Merged
merged 7 commits into from Sep 6, 2017
Merged

Alias Drop#invoke_drop to Drop#[] #6338

merged 7 commits into from Sep 6, 2017

Commits on Aug 30, 2017

  1. alias Drop#invoke_drop to Drop#[] 

    If a drop is mutable, #[] preferes the user-set value over the default (a Jekyll construct).

This leads to scenarios where drop.value and drop["value"] return different values.

By aliasing #invoke_drop to #[], both will respect mutability and return the same value.
    @benbalter
    benbalter committed Aug 30, 2017
    Copy the full SHA
    da6de44 View commit details
    Browse the repository at this point in the history

  2. add tests to ensure drops remain mutable

    @benbalter
    benbalter committed Aug 30, 2017
    Copy the full SHA
    a948998 View commit details
    Browse the repository at this point in the history

  3. make stubbed fallback data method private

    @benbalter
    benbalter committed Aug 30, 2017
    Copy the full SHA
    3ac789c View commit details
    Browse the repository at this point in the history

  4. use the default fallback data method from Drop

    @benbalter
    benbalter committed Aug 30, 2017
    Copy the full SHA
    9394488 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2017

  1. dont add default fallback_data to Drop

    @benbalter
    benbalter committed Sep 5, 2017
    Copy the full SHA
    847ed7f View commit details
    Browse the repository at this point in the history

  2. add failing test for fetch changing mutability

    @benbalter
    benbalter committed Sep 5, 2017
    Copy the full SHA
    3776c44 View commit details
    Browse the repository at this point in the history

  3. Drop#key? should call mutable? not mutable to avoid zeroing mutability

    @benbalter
    benbalter committed Sep 5, 2017
    Copy the full SHA
    c998c59 View commit details
    Browse the repository at this point in the history