Add the ability to yield a message.
#6306
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Standard loggers in Ruby mostly `yield` their messages (this is the default behavior of Ruby's own logger.) Or if there is a block then the message is the topic, a colon is automatically added, and the message is shipped with the topic. Jekyll should conform to this behavior so that it's logger can be passed to libraries that expect this standard behavior.
```ruby
[1] pry(main)> Jekyll.logger.info("Just so you know") # => Just so you know
[2] pry(main)> Jekyll.logger.info("Just so you know", "this is a message") # => Just so you know this is a message
[3] pry(main)> Jekyll.logger.info("Just so you know") { "this is a message" }
# => Just so you know: this is a message
```
parkr
requested changes
Aug 16, 2017
| @@ -79,7 +79,7 @@ def warn(topic, message = nil) | |||
| # | |||
| # Returns nothing | |||
| def error(topic, message = nil) | |||
| writer.error(message(topic, message)) | |||
| writer.error(message(topic, message, &block)) | |||
There was a problem hiding this comment.
Need to add this to the method signature on line 81
| @@ -69,7 +69,7 @@ def info(topic, message = nil) | |||
| # | |||
| # Returns nothing | |||
| def warn(topic, message = nil) | |||
| writer.warn(message(topic, message)) | |||
| writer.warn(message(topic, message, &block)) | |||
There was a problem hiding this comment.
Need to add this to the method signature on line 71 (&block)
|
The original repository is gone so no edits can be made. Rolled this change into #6315. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standard loggers in Ruby mostly
yieldtheir messages (this is the default behavior of Ruby's own logger.) Or if there is a block then the message is the topic, a colon is automatically added, and the message is shipped with the topic. Jekyll should conform to this behavior so that it's logger can be passed to libraries that expect this standard behavior.