Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call to_s on site.url before attempting to concatenate strings #6253

Merged
merged 2 commits into from Jul 30, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/jekyll/filters/url_filters.rb
Expand Up @@ -13,7 +13,9 @@ def absolute_url(input)
return input if Addressable::URI.parse(input).absolute?
site = @context.registers[:site]
return relative_url(input).to_s if site.config["url"].nil?
Addressable::URI.parse(site.config["url"] + relative_url(input)).normalize.to_s
Addressable::URI.parse(
site.config["url"].to_s + relative_url(input)
).normalize.to_s
end

# Produces a URL relative to the domain root based on site.baseurl.
Expand Down
22 changes: 22 additions & 0 deletions test/test_filters.rb
Expand Up @@ -13,6 +13,16 @@ def initialize(opts = {})
end
end

class Value
def initialize(value)
@value = value
end

def to_s
@value.respond_to?(:call) ? @value.call : @value.to_s
end
end

def make_filter_mock(opts = {})
JekyllFilter.new(site_configuration(opts)).tap do |f|
tz = f.site.config["timezone"]
Expand Down Expand Up @@ -423,6 +433,12 @@ def select; end
page_url = "http://example.com/"
assert_equal "http://example.com/", @filter.absolute_url(page_url)
end

should "transform the input URL to a string" do
page_url = "/my-page.html"
filter = make_filter_mock({ "url" => Value.new(proc { "http://example.org" }) })
assert_equal "http://example.org#{page_url}", filter.absolute_url(page_url)
end
end

context "relative_url filter" do
Expand Down Expand Up @@ -500,6 +516,12 @@ def select; end
url << "foo"
assert_equal "/front_matter.erb", page.url
end

should "transform the input baseurl to a string" do
page_url = "/my-page.html"
filter = make_filter_mock({ "baseurl" => Value.new(proc { "/baseurl/" }) })
assert_equal "/baseurl#{page_url}", filter.relative_url(page_url)
end
end

context "strip_index filter" do
Expand Down