bump kramdown to 1.14.0 for rouge 2 support #6183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crunch09
commented
Jun 26, 2017
jekyll.gemspec
Outdated
| @@ -34,7 +34,7 @@ Gem::Specification.new do |s| | |||
| s.add_runtime_dependency("colorator", "~> 1.0") | |||
| s.add_runtime_dependency("jekyll-sass-converter", "~> 1.0") | |||
| s.add_runtime_dependency("jekyll-watch", "~> 1.1") | |||
| s.add_runtime_dependency("kramdown", "~> 1.3") | |||
| s.add_runtime_dependency("kramdown", "~> 1.14", ">= 1.14.0") | |||
There was a problem hiding this comment.
I wasn't sure if we should still allow versions < 1.14 when using rouge 1 but it would make things quite complicated and a bump should still work with rouge 1.
There was a problem hiding this comment.
~> 1.14 is the same as >= 1.14.0, < 2.0.
|
/cc: @jekyll/ecosystem |
parkr
requested changes
Jun 26, 2017
Gemfile
Outdated
| @@ -70,7 +70,7 @@ group :jekyll_optional_dependencies do | |||
| gem "jekyll-gist" | |||
| gem "jekyll-paginate" | |||
| gem "jekyll-redirect-from" | |||
| gem "kramdown", "~> 1.9" | |||
| gem "kramdown", "~> 1.14", ">= 1.14.0" | |||
There was a problem hiding this comment.
This is unnecessary – ~> 1.14 is sufficient. 😄
There was a problem hiding this comment.
Thank you! I always mix up these things :(
jekyll.gemspec
Outdated
| @@ -34,7 +34,7 @@ Gem::Specification.new do |s| | |||
| s.add_runtime_dependency("colorator", "~> 1.0") | |||
| s.add_runtime_dependency("jekyll-sass-converter", "~> 1.0") | |||
| s.add_runtime_dependency("jekyll-watch", "~> 1.1") | |||
| s.add_runtime_dependency("kramdown", "~> 1.3") | |||
| s.add_runtime_dependency("kramdown", "~> 1.14", ">= 1.14.0") | |||
There was a problem hiding this comment.
~> 1.14 is the same as >= 1.14.0, < 2.0.
Crunch09
force-pushed
the
rouge-2-bump-kramdown
branch
from
3c7547a
to
17d7637
Compare
|
Yes, it seemed to work fine at first but e.g. |
DirtyF
approved these changes
Jul 1, 2017
ghost
approved these changes
Jul 2, 2017
parkr
approved these changes
Jul 5, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://kramdown.gettalong.org/news.html
cc: @parkr