Reduce array allocations from StaticFile#path

[ashmaroli]

Summary

Jekyll::StaticFile#path involves duplicating arrays via Array#Compact. So multiple calls to the unmemoized method would result in unnecessary Array allocations.

[DirtyF]

Any possible side-effect due to memoization? Not sure if our tests would catch those.

[ashmaroli]

In theory, a resource's (irrespective of page, document, static-file, layout, etc) path shouldn't change. Additionally, for static-files, there is no equivalent writer (:path=). So, it can be assumed to be a read-only attribute.

If at all something is mutating the path attribute, then that code should be fixed.

[ashmaroli]

Should I freeze the attribute value and see if something breaks / fails..?

[DirtyF]

As you see fit, just want to make sure we don't ship any regression, or that we don't miss any test here 😅

[ashmaroli]

Note: I'll unfreeze the attribute value after some testing..

[DirtyF]

Thanks Ashwin.

[DirtyF]

@jekyllbot: merge +fix