Do not hardcode locale unless certainly necessary #6791
Conversation
|
This was added in #6509. Was it necessary for something, or just boilerplate that got included? |
|
/cc @alextsui05 |
It's required. |
So removing this default could lead to problems if plugins expect it to be there? |
|
Sorry, I wrote that line when adding latin mode and the situation is as ashmaroli says. I don't think there's any particular need other than to clear the error, and this PR looks good to limit setting it only where it's necessary. |
@pathawks Since this default was just added in Ideally, we'd release this as a backport in |
|
If there were enough bug fixes to merit a |
I believe all other reported bugs have been fixed as part of |
| @@ -203,7 +203,10 @@ def slugify(string, mode: nil, cased: false) | |||
| end | |||
|
|
|||
| # Drop accent marks from latin characters. Everything else turns to ? | |||
| string = ::I18n.transliterate(string) if mode == "latin" | |||
| if mode == "latin" | |||
| I18n.config.available_locales = :en if I18n.config.available_locales.empty? | |||
There was a problem hiding this comment.
Should we set available_locales to an array ([:en]) instead?
There was a problem hiding this comment.
I don't think its necessary.
If you were to add a print I18n.config.available_locales immediately after this line, the output would return [:en]
There was a problem hiding this comment.
This code only gets run if mode is set to latin. If it's not you break everyone else's code by removing I18n.config.available_locales = :en from jekyll module which is exactly what happened to me.
There was a problem hiding this comment.
@milosgajdos83 I18n.config.available_locales = :en was specifically added to the Jekyll module for the sole use in the slugify filter.
Please open a new separate issue for better tracking..
|
@jekyllbot: merge +bug |
ghost
removed this from the 
Fixes #6669
We shouldn't be hardcoding locales unnecessarily