Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installation.md #6694

Merged
merged 2 commits into from Jan 20, 2018
Merged

Update installation.md #6694

merged 2 commits into from Jan 20, 2018

Conversation

sashabrava
Copy link
Contributor

While installing Jekyll on Linux, I have noticed that not all the necessary packages were specified in your guide, therefore I offer some updates.

While installing Jekyll on Linux, I have noticed that not all the necessary packages were specified in your guide, therefore I offer some updates.
headers
- [RubyGems](https://rubygems.org/pages/download)
- [GCC](https://gcc.gnu.org/install/) and [Make](https://www.gnu.org/software/make/) (in case your system doesn't have them installed, which you can check by running `gcc -v` and `make -v` in your system's command line interface)
headers (ruby installation can check by running `ruby -v`, development headers can be checked on Ubuntu by running `apt list --installed ruby-dev`)
Copy link
Member

@ashmaroli ashmaroli Jan 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- (ruby installation can check by running `ruby -v`,
+ (ruby installation can be checked by running `ruby -v`,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it is better to make a Passive voice - "(ruby installation can be checked by running ruby -v"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

of course.. I meant to type (ruby installation can be checked by running ruby -v itself 😆 🤦‍♂️

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! 👍

- [GCC](https://gcc.gnu.org/install/) and [Make](https://www.gnu.org/software/make/) (in case your system doesn't have them installed, which you can check by running `gcc -v` and `make -v` in your system's command line interface)
headers (ruby installation can check by running `ruby -v`, development headers can be checked on Ubuntu by running `apt list --installed ruby-dev`)
- [RubyGems](https://rubygems.org/pages/download) (which you can check by running `gem -v`)
- [GCC](https://gcc.gnu.org/install/) and [Make](https://www.gnu.org/software/make/) (in case your system doesn't have them installed, which you can check by running `gcc -v`,`g++ -v` and `make -v` in your system's command line interface)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is g++ necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, otherwise I catch following error:
jekyll

Copy link
Contributor Author

@sashabrava sashabrava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corrected grammar mistake

Copy link
Member

@ashmaroli ashmaroli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@DirtyF DirtyF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sashabrava Thanks for the contribution.

We know Ruby is the hard part to get going.

At one point we'll have to split instructions for the different OS, all this stuff is mostly irrelevant for latest macOS or Windows. I'll happily accept a PR with a dedicated Install for Linux or Install Ruby on your system section with links to up to date guides for each OS.

Everything that can ease the getting started part.

@DirtyF
Copy link
Member

DirtyF commented Jan 20, 2018

@jekyllbot: merge +docs

@jekyllbot jekyllbot merged commit 44ffce9 into jekyll:master Jan 20, 2018
jekyllbot added a commit that referenced this pull request Jan 20, 2018
@jekyll jekyll locked and limited conversation to collaborators Jul 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants