Fix: Add note about posts in context of collections_dir #6680
Conversation
localheinz
force-pushed
the
fix/documentation-collections
branch
2 times, most recently
from
6764d0e
to
78d9d02
Compare
docs/_docs/collections.md
Outdated
|
|
||
| <p>Then Jekyll will look in <code>my_collections/_books</code> for the <code>books</code> collection, and | ||
| in <code>my_collections/_recipes</code> for the <code>recipes</code> collection.</p> | ||
| in <code>my_collections/_recipes</code> for the <code>recipes</code> collection. Since posts and drafts are collections as well, you will need to move the <code>_drafts</code> and <code>_posts</code> directories into <code>my_collections</code> as well.</p> |
There was a problem hiding this comment.
Should we turn this into a warning?
There was a problem hiding this comment.
drafts are not a collection! They're just a temporary holding..
There was a problem hiding this comment.
I've updated my previous PR to confirm that drafts at the root are processed even when a custom collections_dir is set..
There was a problem hiding this comment.
How about the issue, though, that when you have collections in a custom collections directory and posts at the root, that the posts will have a draft status (regardless of whether publishing date is in the past or not)?
Ha, never mind.
localheinz
changed the title
docs/_docs/collections.md
Outdated
|
|
||
| <p>Then Jekyll will look in <code>my_collections/_books</code> for the <code>books</code> collection, and | ||
| in <code>my_collections/_recipes</code> for the <code>recipes</code> collection.</p> | ||
| in <code>my_collections/_recipes</code> for the <code>recipes</code> collection. Since posts and drafts are collections as well, you will need to move the <code>_drafts</code> and <code>_posts</code> directories into <code>my_collections</code> as well.</p> |
There was a problem hiding this comment.
drafts are not a collection! They're just a temporary holding..
localheinz
force-pushed
the
fix/documentation-collections
branch
from
78d9d02
to
d1e88f0
Compare
localheinz
changed the title
localheinz
force-pushed
the
fix/documentation-collections
branch
2 times, most recently
from
9e609f4
to
a73793f
Compare
docs/_docs/collections.md
Outdated
| <h5>Be sure to move posts into custom collections directory</h5> | ||
|
|
||
| <p>If you specify a directory to store all your collections in the same place with <code>collections_dir: my_collections</code>, then you will need to move your <code>_posts</code> directory to <code>my_collections/_post</code>.</p> | ||
| </div> |
There was a problem hiding this comment.
small typo..
- you will need to move your <code>_posts</code> directory to <code>my_collections/_post</code>.
+ you will need to move your <code>_posts</code> directory to <code>my_collections/_posts</code>.
localheinz
force-pushed
the
fix/documentation-collections
branch
from
63180b1
to
6793402
Compare
|
Already done! |
|
/cc @jekyll/documentation |
|
Please unsubscribe the email for the above account. |
|
Thanks @localheinz, this should save some headache to many people 😓 @jekyllbot: merge +docs |
|
Thank you, @ashmaroli, @DirtyF, and of course, @jekyllbot! |
This PR
_postsdirectory in the context of specifying a customcollections_dirFollows #6331.
Related to #6678.
Follows #6679 (comment).