Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Test against Ruby 2.5.0 #6664

Merged
merged 1 commit into from Jan 5, 2018
Merged

CI: Test against Ruby 2.5.0 #6664

merged 1 commit into from Jan 5, 2018

Conversation

jekyllbot
Copy link
Contributor

@jekyllbot jekyllbot commented Jan 3, 2018 •
edited by DirtyF

  • Test against Ruby 2.5.0
  • Stop testing against Ruby 2.1 (EOL)

@DirtyF DirtyF requested a review from a team January 3, 2018 08:25
@DirtyF DirtyF added the tests label Jan 3, 2018
ashmaroli
ashmaroli requested changes Jan 3, 2018
View reviewed changes
Copy link
Member

@ashmaroli ashmaroli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might as well bump all ruby versions in the matrix..

.travis.yml Outdated
- &ruby1 2.5.0
- &ruby2 2.4.2
- &ruby4 2.3.5
- &ruby4 2.2.8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate assignment:

&ruby4 2.3.5
&ruby4 2.2.8

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

parkr
parkr requested changes Jan 3, 2018
View reviewed changes
Copy link
Member

@parkr parkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!!

We test Rouge 1.11 twice. Can you please remove the one which specifies the TEST_SUITE and just leave the second one?

ashmaroli
ashmaroli requested changes Jan 3, 2018
View reviewed changes
Copy link
Member

@ashmaroli ashmaroli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JRuby is now at 9.1.15.0..
And looks like we'll have to drop Cucumber tests for Ruby 2.1 to have Travis go Green again..

parkr
parkr requested changes Jan 3, 2018
View reviewed changes
Copy link
Member

@parkr parkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s fully duplicate so you can remove that part of the matrix entirely.

.travis.yml Outdated
- &jruby jruby-9.1.14.0

matrix:
include:
- rvm: *ruby1
env: TEST_SUITE=test ROUGE=1.11.1
env: TEST_SUITE=test
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just remove this section entirely including rvm above.

@DirtyF
Copy link
Member

DirtyF commented Jan 3, 2018

Travis is green again 💚

@parkr
Copy link
Member

parkr commented Jan 4, 2018

@DirtyF out of curiosity, why did you remove the more specific versions? Using the most up-to-date versions seems like a good idea?

@DirtyF
Copy link
Member

DirtyF commented Jan 4, 2018

@parkr I don't remember CI failing because of an updated patched version of Ruby, added the specificity back with latest versions, travis is still green 💚

parkr
parkr approved these changes Jan 4, 2018
View reviewed changes
Copy link
Member

@parkr parkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

ashmaroli
ashmaroli approved these changes Jan 4, 2018
View reviewed changes
Copy link
Member

@ashmaroli ashmaroli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

Crunch09
Crunch09 approved these changes Jan 4, 2018
View reviewed changes
Copy link
Member

@Crunch09 Crunch09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆕

@parkr
Copy link
Member

parkr commented Jan 5, 2018

I guess we also need to remove 2.1 on AppVeyor?

@parkr
Copy link
Member

parkr commented Jan 5, 2018

Or we set jekyll-watch to 1.x when Ruby 2.1 or below!

@ashmaroli
Copy link
Member

Or we set jekyll-watch to 1.x when Ruby 2.1 or below!

We haven't received any complaints of recent releases of jekyll-watch breaking an existing workflows.. ergo its safe to assume that Jekyll users still on Ruby 2.1 are fine with having to upgrade their Ruby Version..

So, lets drop testing on Ruby 2.1 its EOL anyways..

@parkr
Copy link
Member

parkr commented Jan 5, 2018

👍 to dropping a potentially unsafe version of Ruby. Can happen in another PR.

@DirtyF
Copy link
Member

DirtyF commented Jan 5, 2018 •
edited

#6560 drops support of Ruby 2.1 and 2.2

@parkr
Copy link
Member

parkr commented Jan 5, 2018

#6640 adds dependency update checks to jekyll doctor. I don’t see a PR which removes 2.1. You can add it here too.

@ashmaroli
Copy link
Member

#6640 drops support of Ruby 2.1 and 2.2

I think you pointed towards the wrong PR.. Either ways, existing PRs propose dropping library support for older Rubies entirely.. I was suggesting just stop testing on outdated Ruby versions..

@DirtyF
Copy link
Member

DirtyF commented Jan 5, 2018

I meant #6560

@ashmaroli
Copy link
Member

please drop 2.1 on AppVeyor too..

@DirtyF
CI: Test against Ruby 2.5.0
3f151a2 
- Test against latest patched versions
- Remove duplicate Rouge 1.x testing
- Stop testing EOL Ruby 2.1
@parkr
Copy link
Member

parkr commented Jan 5, 2018

Definitely remove Ruby 2.1, but 2.2 is still in security maintenance. https://www.ruby-lang.org/en/downloads/branches/

Let’s remove 2.1 in this PR.

@parkr
Copy link
Member

parkr commented Jan 5, 2018

Feel free to merge once Travis & AppVeyor are both 💚

@DirtyF
Copy link
Member

DirtyF commented Jan 5, 2018

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit c96289f into master Jan 5, 2018
@jekyllbot jekyllbot deleted the pull/test-ruby-2.5.0 branch January 5, 2018 14:27
jekyllbot added a commit that referenced this pull request Jan 5, 2018
@jekyllbot
Update history to reflect merge of #6664 [ci skip]
7f39de6
@jekyll jekyll locked and limited conversation to collaborators Jul 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DirtyF DirtyF DirtyF left review comments

@parkr parkr parkr approved these changes

@Crunch09 Crunch09 Crunch09 approved these changes

@ashmaroli ashmaroli ashmaroli approved these changes

Assignees
No one assigned
Labels
fix frozen-due-to-age internal tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jekyllbot @DirtyF @parkr @ashmaroli @Crunch09