Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always treat data.layout as a string #6442

Merged
merged 1 commit into from Oct 19, 2017
Merged

Always treat data.layout as a string #6442

merged 1 commit into from Oct 19, 2017

Conversation

bellvat
Copy link
Contributor

@bellvat bellvat commented Oct 19, 2017

Added 'to_s' method to line 146.
Can you review my code change?

@bellvat
Update 'data.layout' as a string.
198873c 
Add 'to_s' method to line 146.
@pathawks
Copy link
Member

Fixes #6436
Fixes #6190

pathawks
pathawks approved these changes Oct 19, 2017
View reviewed changes
Copy link
Member

@pathawks pathawks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work! We just need to wait for our Continuous Integration test suite to give us a green checkmark and this can be merged 👍🏼

@pathawks pathawks changed the title Updated 'data.layout' to a string. Always treat data.layout as a string Oct 19, 2017
@pathawks
Copy link
Member

AppVeyor failure is due to SSL error; unrelated to PR.

@pathawks
Copy link
Member

@jekyllbot: merge +bug

@jekyllbot jekyllbot merged commit 84c2503 into jekyll:master Oct 19, 2017
jekyllbot added a commit that referenced this pull request Oct 19, 2017
@jekyllbot
Update history to reflect merge of #6442 [ci skip]
c0478e2
@pathawks
Copy link
Member

Thanks again, @bellvat! 🎊🌮

This was referenced Oct 19, 2017
Closed
Closed
pathawks pushed a commit that referenced this pull request Oct 20, 2017
@bellvat @pathawks
Backport patch-1 from #6442 to 3.6-stable
a588127
pathawks pushed a commit that referenced this pull request Oct 20, 2017
@bellvat @pathawks
Backport patch-1 from #6442 to 3.6-stable
035c6e0
@pathawks pathawks mentioned this pull request Oct 20, 2017
Closed
@jekyll jekyll locked and limited conversation to collaborators Jul 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pathawks pathawks pathawks approved these changes

Assignees
No one assigned
Labels
fix frozen-due-to-age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bellvat @pathawks @jekyllbot