Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat data.layout as a string #6436

Closed
6 tasks
first-timers bot opened this issue Oct 18, 2017 · 4 comments
Closed
6 tasks

Treat data.layout as a string #6436

first-timers bot opened this issue Oct 18, 2017 · 4 comments
Assignees
Labels

Comments

@first-timers
Copy link

first-timers bot commented Oct 18, 2017

πŸ†•πŸ₯☝ First Timers Only.

This issue is reserved for people who never contributed to Open Source before. We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you πŸ’

About First Timers Only.

πŸ€” What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

πŸ“‹ Step by Step

  • πŸ‘Œ Join the team: Add yourself to a Jekyll affinity team.

    Go to teams.jekyllrb.com join a team that best fits your interests. Once you click the link to join a team, you will soon recieve an email inviting you to join the Jekyll organization.

  • πŸ™‹ Claim this issue: Comment below.

    Leave a comment that you have claimed this issue.

  • πŸ“ Update the file lib/jekyll/renderer.rb in the jekyll repository (press the little pen Icon) and edit the line as shown below.

@@ -143,7 +143,7 @@ def invalid_layout?(layout)
     # Returns String rendered content
     def place_in_layouts(content, payload, info)
       output = content.dup
-      layout = layouts[document.data["layout"]]
+      layout = layouts[document.data["layout"].to_s]
       validate_layout(layout)
 
       used = Set.new([layout])
  • πŸ’Ύ Commit your changes

  • πŸ”€ Start a Pull Request. There are two ways how you can start a pull request:

    1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

    2. You can edit files directly in your browser

  • 🏁 Done Ask in comments for a review :)

πŸ€”β“ Questions

Leave a comment below!

This issue was created by First-Timers-Bot.

@pathawks
Copy link
Member

See also: #6190

@bellvat
Copy link
Contributor

bellvat commented Oct 19, 2017

Hi!

I'm new to the open source community and would like to claim this issue as my first open source contribution.

Regards,
Monica

@pathawks
Copy link
Member

That’s awesome! Thanks @bellvat.

Please let me know if you have any questions.

@pathawks
Copy link
Member

Closed via #6442

@jekyll jekyll locked and limited conversation to collaborators Jul 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants