Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User name instead of property for Twitter #437

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tordans
Copy link
Contributor

@tordans tordans commented Mar 7, 2021

Facebook uses property, but twitter specifies name`.

See https://developer.twitter.com/en/docs/twitter-for-websites/cards/guides/getting-started#opengraph

Open Graph protocol also specifies the use of property and content attributes for markup (<meta property="og:image" content="http://example.com/ogp.jpg"/>) while Twitter cards use name and content.

Or for example the "Sample Code" for the Summary Card https://developer.twitter.com/en/docs/twitter-for-websites/cards/overview/summary


This was initially added in 7898489

Facebook uses `property`, but `twitter specifies `name`.

See https://developer.twitter.com/en/docs/twitter-for-websites/cards/guides/getting-started#opengraph
> Open Graph protocol also specifies the use of property and content attributes for markup (<meta property="og:image" content="http://example.com/ogp.jpg"/>) while Twitter cards use name and content.

Or for example the "Sample Code" for the Summary Card https://developer.twitter.com/en/docs/twitter-for-websites/cards/overview/summary
Copy link
Member

@ashmaroli ashmaroli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, let's use the name attribute for metadata under twitter: namespace consistently.

@ashmaroli ashmaroli requested a review from mattr- October 8, 2021 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants