New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: fix offenses in specs #248
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
periods in regexps need to be escaped
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! One comment.
1183e39
to
1b161c7
Compare
@ashmaroli Why did you convert to strings? |
Regexp and String both respond to a #match method in RSpec tests Converting simple regexps (those that do not contain regex meta-characters) to strings improves readability.. Moreover, there are existing instances of "matching with strings" in jekyll-feed/spec/jekyll-feed_spec.rb Line 49 in e250bdb
|
@jekyllbot: merge +dev |
Applied some style rules following this discussion: #228 (comment)