Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document setting up extensionless feed paths #238

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Document setting up extensionless feed paths #238

wants to merge 2 commits into from

Conversation

sonicdoe
Copy link

Resolves #237.

benbalter
benbalter reviewed Jul 10, 2018
View reviewed changes
README.md Outdated
@@ -45,6 +45,8 @@ feed:

To note, you shouldn't have to do this unless you already have a feed you're using, and you can't or wish not to redirect existing subscribers.

<span role="img" aria-label="Warning">⚠️</span> If your feed path does not end with `.xml`, you'll need to configure your web server to serve the proper content type. Alternatively, you can specify e.g. `feed/index.xml` to serve your feed from `/feed/`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe using :warning: here will result in similar markup.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VoiceOver on macOS reads it slightly differently. However, I’ve noticed that GitHub converts it to their <g-emoji> custom element anyway, so I’ve changed it to :warning:. Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DirtyF DirtyF DirtyF approved these changes

@benbalter benbalter benbalter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sonicdoe @DirtyF @benbalter @ashmaroli