Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensionless feed paths #237

Open
sonicdoe opened this issue Jul 9, 2018 · 3 comments
Open

Extensionless feed paths #237

sonicdoe opened this issue Jul 9, 2018 · 3 comments

Comments

@sonicdoe
Copy link

sonicdoe commented Jul 9, 2018

For example, if you set the feed path to feed, /feed will return a Content-Type of application/octet-stream (instead of text/xml).

We could automatically place the feed in an index.xml (for example, /feed/index.xml) so the server sends the correct content type. Alternatively, we could document the index.xml workaround in the Already have a feed path? section.

See also #112 (more or less a duplicate).

@benbalter
Copy link
Contributor

One concern I'd have with the "automatic" route, is that users may write /feed and want /feed (an extension-less file), or may enter /feed, but really want /feed/ (which would be /feed/index.xml). This is confusion we already see in Jekyll core. Given that plus the added complexity to implement, my vote would be the documentation route.

@sonicdoe
Copy link
Author

sonicdoe commented Jul 9, 2018

Having feed generate feed/index.xml is comparable to Jekyll’s own behavior: about.md actually generates about/index.html (which is available under /about, /about/, and /about/index.html).

The only concern I have with the documentation route is that it’d (still) be possible to serve an invalid feed without really being aware of it. For example, /feed with a Content-Type of application/octet-stream might work with one feed reader but certainly won’t work with every feed reader.

@pathawks
Copy link
Member

pathawks commented Jul 9, 2018

Alternatively, we could document the index.xml workaround in the Already have a feed path? section.

I think this might be the way to go. If I have configured my server to serve the proper mime type for /feed, then this plugin should not force me to instead use /feed/index.xml

sonicdoe added a commit to sonicdoe/jekyll-feed that referenced this issue Jul 10, 2018
sonicdoe added a commit to sonicdoe/jekyll-feed that referenced this issue Jul 10, 2018
sonicdoe added a commit to sonicdoe/jekyll-feed that referenced this issue Jul 10, 2018
schuer added a commit to DECAF/blog.decaf.de that referenced this issue Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants