Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update helpers.js #614

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

duongkhoangiam
Copy link

@duongkhoangiam duongkhoangiam commented Nov 30, 2020

Completed create slug from string in Javascript

Fixes #613

Completed create slug from string in Javascript
@mertkahyaoglu
Copy link
Member

mertkahyaoglu commented Nov 30, 2020

@duongkhoangiam Hey, thanks for the pr. Could you explain briefly what this pr solves?

Also, some tests are not passing here. We should fix them and add tests for new cases this pr fixes.

Edit: No worries. I just saw the issue and updated the description.

@duongkhoangiam
Copy link
Author

When i using admin to created new post. the filename (path) leave blank to automatic generate is not completed for latin language, i am not sure this fix is solved or not because not sure the process generate file name from ruby or nodejs code.
I hope we can add some nicely slugify to generate for latin language

Example when i type title is "Trump gây bàn tán vì ngồi bàn họp nhỏ bất thường"
The filename generate is "2020-11-28-trump-gay-ban-tan-vi-ngi-ban-hp-nh-bt-thng.md"

This not correct because removed some characters.
the correct is "2020-11-28-trump-gay-ban-tan-vi-ngoi-ban-hop-nho-bat-thuong.md"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Completed create slug from string in Javascript
2 participants