Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unneeded param type #59

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

remove unneeded param type #59

wants to merge 1 commit into from

Conversation

Crunch09
Copy link
Member

Hi,
GET /users/:username/repos only returns public repos by default and public isn't even one of the available options for the type param.
See https://developer.github.com/v3/repos/#list-user-repositories for more
information.

@Crunch09
remove unneeded param type
d0d4c43 
GET /users/:username/repos only returns public repos by default.
See https://developer.github.com/v3/repos/#list-user-repositories for more
information.
@parkr
Copy link
Member

parkr commented May 26, 2016

@benbalter Oh, this needed type => public before... did this recently change?

@parkr
Copy link
Member

parkr commented Jun 20, 2016 •
edited

I think we meant to do /user/repos: https://developer.github.com/v3/repos/#list-your-repositories, but maybe that's not what we should be looking for.

@Crunch09
Copy link
Member Author

@parkr Yes, i think it's good that we don't use /user/repos because as of now the user doesn't need to be authenticated if he / she only wants to access public fields and this would change if we used that call.

@benbalter
Copy link
Contributor

Should this be visibility?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pending-rebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Crunch09 @parkr @benbalter @ashmaroli