Remove obsolete SetAccess calls #1
Conversation
This removes the obsolete SetAccess calls that were removed in Catalina, and, subsequently, in go-keychain. There *should* be no impact to functionality here - I'm assuming that we'd be using access defaults here now, given that the calls here seem to have been removed without any alternative.
|
Draft for now, I'm not too sure if we can remove other code and API still. |
|
Hmm, based on 99designs#66 (comment), I'm kind of wondering what we do here. Sounds like this is necessary to ensure there's a password prompt on dependencies that may not affect us per se, but we probably account for anyway. There is a documented API there (use of https://developer.apple.com/documentation/security/1392184-secaclupdateauthorizations) instead, so that sounds like it would be a good jumping point here to try and address this. Going to stop short on this now for time, but we should probably revisit sooner rather than later so that we can get these warnings out of Boundary development (it does seem like it's breaking a few vim-go commands, guessing maybe because of the warning output it generates). |
|
Going to close this for now to clean up old PRs in my backlog. I think we'll have to defer this until we resolve the issue of actually transitioning the aforementioned API over, versus flat out removing things altogether. |
This removes the obsolete SetAccess calls that were removed in Catalina,
and, subsequently, in go-keychain.
There should be no impact to functionality here - I'm assuming that
we'd be using access defaults here now, given that the calls here seem
to have been removed without any alternative.