Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to TypeScript #119

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Migrate to TypeScript #119

wants to merge 8 commits into from

Conversation

devrnt
Copy link

@devrnt devrnt commented May 3, 2020

Finished @jeetiss work.

Changes

  • Use tsdx. This results in dropping direct dev-dependencies like eslint, @babel, @rollup
  • Main index.js migrated to index.tsx
  • index.js test migrated to TypeScript
  • Increased size-limit to 420 B

The current size of the compiled index.js is 419 bytes.

@devrnt
Copy link
Author

devrnt commented May 3, 2020

Okay, commits should be squashed. --updateSnapshot flag should be removed from the test script

@jeetiss
Copy link
Owner

jeetiss commented May 6, 2020

wow, thanks @devrnt
I'm going to review this in the week

@JackEdwardLyons
Copy link

Looking forward to the TS addon here :)

@FernandoChu
Copy link

Same here :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@devrnt @jeetiss @JackEdwardLyons @FernandoChu