feat(cli/lib): fix words requests and add environ. variables for login #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This closes #62 by adding environment variables for API key. It also fixes words requests, both on the library (missing struct flattening) and on the CLI side (Option<T>). The latter solution was found in discussion: clap-rs/clap#4427.
jeertmans
added
bug
|
Thank you for updating CHANGELOG.md! Always feel free to edit it. |
for more information, see https://pre-commit.ci
|
Waiting response for #4697 to see if I can avoid adding If I cannot avoid, I will create another structure |
|
Seems like the problem mentioned above is "work in progress" for Clap, but I implemented a workaround using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #62 by adding environment variables for API key. It also fixes words requests, both on the library (missing struct flattening) and on the CLI side (Option). The latter solution was found in discussion: clap-rs/clap#4427.