Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

table: handle negative WidthMax values; fixes #285 #289

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Conversation

jedib0t
Copy link
Owner

@jedib0t jedib0t commented Jan 4, 2024

Proposed Changes

  • If a column's WidthMax attribute is set to negative, handle it similar to 0

Fixes #285.

Copy link

sonarcloud bot commented Jan 4, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
86.7% Duplication on New Code

See analysis details on SonarCloud

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7412751806

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 7411947532: 0.0%
Covered Lines: 3368
Relevant Lines: 3368

💛 - Coveralls

@jedib0t jedib0t merged commit f26db87 into main Jan 4, 2024
5 checks passed
@jedib0t jedib0t deleted the fix-285 branch January 4, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The upgrade from v6.4.0 to v6.4.1 results in empty table content when used in our product.
2 participants