New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
list: add unindent all function #217
Conversation
Pull Request Test Coverage Report for Build 2786577285
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add a unit-test to verify this functionality and ensure that Render() renders properly and does not get broken?
Edit: I really appreciate the contribution! ❤️
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Ok, added some tests! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
@mneira10 I've merged the PR. Let me know if you need a tag, or if it can wait. |
A tag would be nice! But I'm not in a hurry, I can wait for it to get bundled with other stuff for a little bit |
Tags are cheap. I’ll get you one within the hour.
…________________________________
From: Mauricio Neira ***@***.***>
Sent: Tuesday, August 2, 2022 8:08:04 PM
To: jedib0t/go-pretty ***@***.***>
Cc: Naveen Mahalingam ***@***.***>; State change ***@***.***>
Subject: Re: [jedib0t/go-pretty] list: add unindent all function (PR #217)
A tag would be nice! But I'm not in a hurry, I can wait for it to get bundled with other stuff for a little bit
—
Reply to this email directly, view it on GitHub<#217 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AJGJS34AW2D6EXRJHUVXKMTVXHPBJANCNFSM55J56PNQ>.
You are receiving this because you modified the open/close state.Message ID: ***@***.***>
|
Proposed Changes
This adds a function to unindent the list item to the base of the list, regardless of the indentation level its in.
I wrote this up after needing it in my personal projects. WDYT?