Batch insert: fix inserting constant 'null' #1762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenschlansker
force-pushed
the
batch-insert-null
branch
2 times, most recently
from
82a6d02
to
361562e
Compare
leaumar
reviewed
Sep 24, 2020
| @@ -67,6 +67,21 @@ public void testInsertSingleIteratorNoTx() { | |||
| assertThat(b.size()).isEqualTo(2); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testBindConstantNull() { | |||
| UsesBatching b = handle.attach(UsesBatching.class); | |||
There was a problem hiding this comment.
avoid single-letter variables please (aside from the meme i for iterations, I'd say Handle h at most could also be a meme in our context since it's so common)
There was a problem hiding this comment.
Ah, this is all just clone of existing tests, with only one other change...
There was a problem hiding this comment.
Sounds like the improvement could be made in 2 places :)
|
|
||
| b.withConstantValue(ids, null); | ||
|
|
||
| assertThat(b.size()).isEqualTo(5); |
There was a problem hiding this comment.
This isn't a Collection, so that doesn't apply.
stevenschlansker
force-pushed
the
batch-insert-null
branch
from
361562e
to
d5df6a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1761