Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typing error jquery.terminal is not a module #901

Merged
merged 1 commit into from Sep 15, 2023
Merged

Conversation

KiddoV
Copy link
Contributor

@KiddoV KiddoV commented Sep 15, 2023

Fix for type error when import terminal from 'jquery.terminal' you got the error:

File '[.../node_modules/jquery.terminal/js/jquery.terminal.d.ts' is not a module.

Possible fix for issues:
#844
#849 (comment)

Fix for typing error when import ``jquery.terminal`` you got the error: File '[.../node_modules/jquery.terminal/js/jquery.terminal.d.ts' is not a module.
@jcubic
Copy link
Owner

jcubic commented Sep 15, 2023

Thanks for the fix. Will release a new version 2.37.2 with this.

@coveralls
Copy link

Coverage Status

coverage: 81.798%. remained the same when pulling c1428be on KiddoV:devel into 73a0060 on jcubic:devel.

@jcubic jcubic merged commit 1b7fecf into jcubic:devel Sep 15, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants