allow usage of String instance in greetings #936

jcubic · Apr 29, 2024 · aaa1295 · aaa1295
1 parent f2ee6bb
commit aaa1295
Show file tree

Hide file tree

Showing 7 changed files with 13 additions and 12 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,7 @@
 ## 2.41.0
 ### Features
 * allow to use class and other attributes in style XML tags (like `<bold/>` or `<glow/>`)
+* allow usage of String instance in greetings [#936](https://github.com/jcubic/jquery.terminal/issues/936)
 ### Bugfix
 * fix alt image attribute
 * fix visible formatting in prompt after animated exec [#938](https://github.com/jcubic/jquery.terminal/issues/938)

diff --git a/js/jquery.terminal-2.40.6.js b/js/jquery.terminal-2.40.6.js
@@ -41,7 +41,7 @@
  *
  * broken image by Sophia Bai from the Noun Project (CC-BY)
  *
- * Date: Mon, 29 Apr 2024 13:41:31 +0000
+ * Date: Mon, 29 Apr 2024 13:58:36 +0000
  */
 /* global define, Map, BigInt */
 /* eslint-disable */
@@ -5312,7 +5312,7 @@
     // -------------------------------------------------------------------------
     $.terminal = {
         version: 'DEV',
-        date: 'Mon, 29 Apr 2024 13:41:31 +0000',
+        date: 'Mon, 29 Apr 2024 13:58:36 +0000',
         // colors from https://www.w3.org/wiki/CSS/Properties/color/keywords
         color_names: [
             'transparent', 'currentcolor', 'black', 'silver', 'gray', 'white',
@@ -8476,7 +8476,7 @@
                 self.echo(self.signature, {finalize: a11y_hide, formatters: false});
             } else if (settings.greetings) {
                 var type = typeof settings.greetings;
-                if (type === 'string') {
+                if (type === 'string' || type instanceof String) {
                     self.echo(settings.greetings);
                 } else if (type === 'function') {
                     self.echo(function() {

diff --git a/js/jquery.terminal-2.40.6.min.js b/js/jquery.terminal-2.40.6.min.js
diff --git a/js/jquery.terminal-src.js b/js/jquery.terminal-src.js
@@ -8476,7 +8476,7 @@
                 self.echo(self.signature, {finalize: a11y_hide, formatters: false});
             } else if (settings.greetings) {
                 var type = typeof settings.greetings;
-                if (type === 'string') {
+                if (type === 'string' || type instanceof String) {
                     self.echo(settings.greetings);
                 } else if (type === 'function') {
                     self.echo(function() {

diff --git a/js/jquery.terminal.js b/js/jquery.terminal.js
@@ -41,7 +41,7 @@
  *
  * broken image by Sophia Bai from the Noun Project (CC-BY)
  *
- * Date: Mon, 29 Apr 2024 13:41:31 +0000
+ * Date: Mon, 29 Apr 2024 13:58:36 +0000
  */
 /* global define, Map, BigInt */
 /* eslint-disable */
@@ -5312,7 +5312,7 @@
     // -------------------------------------------------------------------------
     $.terminal = {
         version: 'DEV',
-        date: 'Mon, 29 Apr 2024 13:41:31 +0000',
+        date: 'Mon, 29 Apr 2024 13:58:36 +0000',
         // colors from https://www.w3.org/wiki/CSS/Properties/color/keywords
         color_names: [
             'transparent', 'currentcolor', 'black', 'silver', 'gray', 'white',
@@ -8476,7 +8476,7 @@
                 self.echo(self.signature, {finalize: a11y_hide, formatters: false});
             } else if (settings.greetings) {
                 var type = typeof settings.greetings;
-                if (type === 'string') {
+                if (type === 'string' || type instanceof String) {
                     self.echo(settings.greetings);
                 } else if (type === 'function') {
                     self.echo(function() {

diff --git a/js/jquery.terminal.min.js b/js/jquery.terminal.min.js
diff --git a/js/jquery.terminal.min.js.map b/js/jquery.terminal.min.js.map