Merge pull request #896 from antoineol/master

fix: typing of terminalObjectFunction (this)
jcubic · Aug 16, 2023 · 368b0f3 · 368b0f3
2 parents 1195f78 + df55072
commit 368b0f3
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/js/jquery.terminal.d.ts b/js/jquery.terminal.d.ts
@@ -22,7 +22,7 @@ type TypeOrPromise<T> = T | PromiseLike<T>;
 
 declare namespace JQueryTerminal {
     type interpreterFunction = (this: JQueryTerminal, command: string, term: JQueryTerminal) => any;
-    type terminalObjectFunction = (...args: (string | number | RegExp)[]) => (void | TypeOrPromise<simpleEchoValue>);
+    type terminalObjectFunction = (this: JQueryTerminal, ...args: (string | number | RegExp)[]) => (void | TypeOrPromise<simpleEchoValue>);
     type Interpreter = string | interpreterFunction | ObjectInterpreter;
     type ObjectInterpreter = {
         [key: string]: ObjectInterpreter | terminalObjectFunction;

diff --git a/test.ts b/test.ts
@@ -47,6 +47,11 @@ $('.term').terminal([obj_interpreter]);
 $('.term').terminal(["foo.php", obj_interpreter]);
 $('.term').terminal(["foo.php", obj_interpreter, function(command) {
 }]);
+$('.term').terminal({
+    help: function () {
+        this.echo('Help command');
+    }
+});
 
 class Foo {
     x: string;

diff --git a/tsconfig.json b/tsconfig.json
@@ -2,7 +2,8 @@
     "compilerOptions": {
         "target": "es6",
         "module": "commonjs",
-        "lib": ["es2015", "ES2018.Promise", "dom"]
+        "lib": ["es2015", "ES2018.Promise", "dom"],
+        "noImplicitThis": true
     },
     "exclude": ["npm"]
 }