fix rendering empty lines in prompt #890

jcubic · Jul 29, 2023 · 1a53bc3 · 1a53bc3
1 parent ea9e86a
commit 1a53bc3
Show file tree

Hide file tree

Showing 8 changed files with 18 additions and 17 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,7 @@
 * fix CMD wrapping when prompt is empty [#882](https://github.com/jcubic/jquery.terminal/issues/882)
 * fix paused terminal when using array as interpreter and RPC without system describe
 * fix edge case of disappearing content after refresh [#871](https://github.com/jcubic/jquery.terminal/issues/871)
+* fix rendering empty lines prompt and during typing animation [#890](https://github.com/jcubic/jquery.terminal/issues/890)
 
 ## 2.36.0
 ### Features

diff --git a/README.md b/README.md
@@ -8,7 +8,7 @@
 [![npm](https://img.shields.io/badge/npm-DEV-blue.svg)](https://www.npmjs.com/package/jquery.terminal)
 ![bower](https://img.shields.io/badge/bower-DEV-yellow.svg)
 [![Build and test](https://github.com/jcubic/jquery.terminal/actions/workflows/build.yaml/badge.svg?branch=devel&event=push)](https://github.com/jcubic/jquery.terminal/actions/workflows/build.yaml)
-[![Coverage Status](https://coveralls.io/repos/github/jcubic/jquery.terminal/badge.svg?branch=devel&e91d8ab98ab7a99d82093f92146b5e92)](https://coveralls.io/github/jcubic/jquery.terminal?branch=devel)
+[![Coverage Status](https://coveralls.io/repos/github/jcubic/jquery.terminal/badge.svg?branch=devel&75da0f6ae07388cf17379f7dcd13e04f)](https://coveralls.io/github/jcubic/jquery.terminal?branch=devel)
 ![downloads](https://img.shields.io/npm/dm/jquery.terminal.svg?style=flat)
 [![Paid Support](https://data.jsdelivr.com/v1/package/npm/jquery.terminal/badge?style=rounded)](https://www.jsdelivr.com/package/npm/jquery.terminal)
 [![](https://img.shields.io/badge/paid-support-354465.svg)](https://support.jcubic.pl/)

diff --git a/js/jquery.terminal-2.36.0.js b/js/jquery.terminal-2.36.0.js
@@ -41,7 +41,7 @@
  *
  * broken image by Sophia Bai from the Noun Project (CC-BY)
  *
- * Date: Tue, 04 Jul 2023 19:13:23 +0000
+ * Date: Sat, 29 Jul 2023 11:57:12 +0000
  */
 /* global define, Map */
 /* eslint-disable */
@@ -3511,7 +3511,7 @@
                 var lines = $.terminal.split_equal(tmp_prompt, num_chars);
                 lines = lines.map(function(line) {
                     return line.replace(/^\uFFFF+/, '');
-                }).filter(Boolean);
+                });
                 lines = lines.map(function(line) {
                     if (!$.terminal.have_formatting(line)) {
                         return '[[;;]' + $.terminal.escape_brackets(line) + ']';
@@ -5277,7 +5277,7 @@
     // -------------------------------------------------------------------------
     $.terminal = {
         version: 'DEV',
-        date: 'Tue, 04 Jul 2023 19:13:23 +0000',
+        date: 'Sat, 29 Jul 2023 11:57:12 +0000',
         // colors from https://www.w3.org/wiki/CSS/Properties/color/keywords
         color_names: [
             'transparent', 'currentcolor', 'black', 'silver', 'gray', 'white',
@@ -10475,8 +10475,8 @@
                                 if (appending_to_partial) {
                                     partial = wrapper;
                                 } else if (data.newline && partial.length) {
-                                    //wrapper = $('<div/>');
-                                    //partial = $();
+                                    wrapper = $('<div/>');
+                                    partial = $();
                                 }
                                 data.finalize(wrapper);
                             } else {

diff --git a/js/jquery.terminal-2.36.0.min.js b/js/jquery.terminal-2.36.0.min.js
diff --git a/js/jquery.terminal-src.js b/js/jquery.terminal-src.js
@@ -3511,7 +3511,7 @@
                 var lines = $.terminal.split_equal(tmp_prompt, num_chars);
                 lines = lines.map(function(line) {
                     return line.replace(/^\uFFFF+/, '');
-                }).filter(Boolean);
+                });
                 lines = lines.map(function(line) {
                     if (!$.terminal.have_formatting(line)) {
                         return '[[;;]' + $.terminal.escape_brackets(line) + ']';

diff --git a/js/jquery.terminal.js b/js/jquery.terminal.js
@@ -41,7 +41,7 @@
  *
  * broken image by Sophia Bai from the Noun Project (CC-BY)
  *
- * Date: Tue, 04 Jul 2023 19:13:23 +0000
+ * Date: Sat, 29 Jul 2023 11:57:12 +0000
  */
 /* global define, Map */
 /* eslint-disable */
@@ -3511,7 +3511,7 @@
                 var lines = $.terminal.split_equal(tmp_prompt, num_chars);
                 lines = lines.map(function(line) {
                     return line.replace(/^\uFFFF+/, '');
-                }).filter(Boolean);
+                });
                 lines = lines.map(function(line) {
                     if (!$.terminal.have_formatting(line)) {
                         return '[[;;]' + $.terminal.escape_brackets(line) + ']';
@@ -5277,7 +5277,7 @@
     // -------------------------------------------------------------------------
     $.terminal = {
         version: 'DEV',
-        date: 'Tue, 04 Jul 2023 19:13:23 +0000',
+        date: 'Sat, 29 Jul 2023 11:57:12 +0000',
         // colors from https://www.w3.org/wiki/CSS/Properties/color/keywords
         color_names: [
             'transparent', 'currentcolor', 'black', 'silver', 'gray', 'white',
@@ -10475,8 +10475,8 @@
                                 if (appending_to_partial) {
                                     partial = wrapper;
                                 } else if (data.newline && partial.length) {
-                                    //wrapper = $('<div/>');
-                                    //partial = $();
+                                    wrapper = $('<div/>');
+                                    partial = $();
                                 }
                                 data.finalize(wrapper);
                             } else {

diff --git a/js/jquery.terminal.min.js b/js/jquery.terminal.min.js
diff --git a/js/jquery.terminal.min.js.map b/js/jquery.terminal.min.js.map