Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#171] Allow running on JDK 8 and possibly on JDK 7 as well. Fixes #171 #204

Merged
merged 1 commit into from Jun 23, 2018

Conversation

beikov
Copy link
Contributor

@beikov beikov commented Jun 22, 2018

Fix for #171

@nickl-
Copy link
Contributor

nickl- commented Jun 22, 2018

I see what you are trying to accomplish, not sure why it involves obfuscating the IllegalAccessError though.

@beikov
Copy link
Contributor Author

beikov commented Jun 22, 2018

Maybe I'm missing the exact line you are referring to, but IllegalAccessError isn't a subtype of Exception but only of Error and thus also Throwable so AFAICT there is no obfuscation.

@nickl-
Copy link
Contributor

nickl- commented Jun 22, 2018

@beikov you are correct, my mistake. Error is not caught by Exception. My bad!

I still can't help wondering if we're doctoring the symptoms instead of fixing the problem. Why does JDK8 have to interpret the newer api calls? Can that not be avoided?

@beikov
Copy link
Contributor Author

beikov commented Jun 22, 2018

Well, because the JVM loads referenced classes due to the initialization of the enum and on Java 8 the StackWalker isn't available. Another possible fix is to make use of the MR-JAR feature, but that would require changes in the build which I wanted to avoid.

@nickl-
Copy link
Contributor

nickl- commented Jun 23, 2018

Oh crap so the enum gets completely referenced when initialized... grrrr that's annoying.

So basically this makes switching capabilities as an enum useless, we should take the whole SecuredPrivileged as an enum implementation back to the drawing board and refactor it into a class or something.

Damn that sux! Worked great in theory... =(

@jplock
Copy link

jplock commented Jun 25, 2018

@chibash when can this be included into a future release?

@chibash
Copy link
Member

chibash commented Jun 26, 2018

OK, what about releasing within a week unless I see an objection?

@johnou
Copy link

johnou commented Jun 26, 2018

@chibash sounds good, thanks!

@chibash
Copy link
Member

chibash commented Jul 1, 2018

I've released 3.23.1-GA. It will be soon available from maven as well.

@jplock
Copy link

jplock commented Jul 1, 2018

Thank you @chibash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants