New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#171] Allow running on JDK 8 and possibly on JDK 7 as well. Fixes #171 #204
Conversation
I see what you are trying to accomplish, not sure why it involves obfuscating the |
Maybe I'm missing the exact line you are referring to, but |
@beikov you are correct, my mistake. I still can't help wondering if we're doctoring the symptoms instead of fixing the problem. Why does JDK8 have to interpret the newer api calls? Can that not be avoided? |
Well, because the JVM loads referenced classes due to the initialization of the enum and on Java 8 the StackWalker isn't available. Another possible fix is to make use of the MR-JAR feature, but that would require changes in the build which I wanted to avoid. |
Oh crap so the enum gets completely referenced when initialized... grrrr that's annoying. So basically this makes switching capabilities as an enum useless, we should take the whole Damn that sux! Worked great in theory... =( |
@chibash when can this be included into a future release? |
OK, what about releasing within a week unless I see an objection? |
@chibash sounds good, thanks! |
I've released 3.23.1-GA. It will be soon available from maven as well. |
Thank you @chibash |
Fix for #171