Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JASSIST-270: Add support for the new Dynamic constant (17) created in java 11 #272

Merged
merged 6 commits into from Aug 31, 2019

Conversation

richbolen
Copy link

No description provided.

@richbolen richbolen changed the title Add support for the new Dynamic constant (17) created in java 11 JASSIST-270: Add support for the new Dynamic constant (17) created in java 11 Aug 20, 2019
Copy link

@camron-johnson camron-johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does CONST_Dynamic need to be defined at the top of ConstPool.java?

src/main/javassist/bytecode/Bytecode.java Outdated Show resolved Hide resolved
src/test/javassist/bytecode/BytecodeTest.java Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
@richbolen
Copy link
Author

@camron-johnson I added CONST_Dynamic to the top of ConstPool.java

@richbolen
Copy link
Author

I bumped the version in the pom.xml to 3.25.1-GA. Not sure that is correct. If not I'll revert that change.

@camron-johnson
Copy link

I bumped the version in the pom.xml to 3.25.1-GA. Not sure that is correct. If not I'll revert that change.

I think that is fine

@chibash chibash merged commit 3dcbf5e into jboss-javassist:master Aug 31, 2019
chibash added a commit that referenced this pull request Sep 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants