Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK11: Add support for the CONSTANT_Dynamic 17 constant introduced in Java 11 #270

Closed
richbolen opened this issue Aug 14, 2019 · 11 comments
Closed

Comments

@richbolen
Copy link

Java 11 introduced a new constant called Constant_Dynamic (defined here https://docs.oracle.com/javase/specs/jvms/se11/html/jvms-4.html#jvms-4.4-210). When running junit tests using powermock on the Java 11 I get this error: invalid constant type: 17 at 130. Support for this constant needs to be added to the ConstPool class.

@chibash
Copy link
Member

chibash commented Aug 15, 2019

OK, I'll work on this.

@richbolen
Copy link
Author

I've got it implemented locally. I can submit a PR. I'm still working on the unit test but I could submit what I have.

@richbolen
Copy link
Author

I don't have permission to submit a PR but would be happy to if you are interested.

@chibash
Copy link
Member

chibash commented Aug 19, 2019

I think anyone can submit a pull request. They are not allowed to merge it, though.

@richbolen
Copy link
Author

Yes. It was a issue with the macos and SSH keys. Created PR #272

@camron-johnson
Copy link

Is there any update on the addition of Constant_Dynamic to Javassist?

@Bophie
Copy link

Bophie commented Aug 24, 2019 via email

chibash added a commit that referenced this issue Sep 1, 2019
@valfirst
Copy link

valfirst commented Oct 2, 2019

@chibash are there any plans to release a new version with this feature?

@chibash
Copy link
Member

chibash commented Oct 2, 2019

I've just released. It'll be available from maven within several days.

odl-github pushed a commit to opendaylight/odlparent that referenced this issue Oct 10, 2019
3.25 fixes:
- jboss-javassist/javassist#72
- jboss-javassist/javassist#241
- jboss-javassist/javassist#242
- jboss-javassist/javassist#246
- jboss-javassist/javassist#252
3.26 fixes:
- jboss-javassist/javassist#265
- jboss-javassist/javassist#270
- jboss-javassist/javassist#271
- jboss-javassist/javassist#275

Of these #270 is most important, as it fixes an issue we've seen
with powermock downstream.

Change-Id: Ib4d75d6411e71438436249a8eb9313ccf4411ca2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
odl-github pushed a commit to opendaylight/odlparent that referenced this issue Oct 17, 2019
3.25 fixes:
- jboss-javassist/javassist#72
- jboss-javassist/javassist#241
- jboss-javassist/javassist#242
- jboss-javassist/javassist#246
- jboss-javassist/javassist#252
3.26 fixes:
- jboss-javassist/javassist#265
- jboss-javassist/javassist#270
- jboss-javassist/javassist#271
- jboss-javassist/javassist#275

Of these #270 is most important, as it fixes an issue we've seen
with powermock downstream.

Change-Id: Ib4d75d6411e71438436249a8eb9313ccf4411ca2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 6a404f1)
odl-github pushed a commit to opendaylight/odlparent that referenced this issue Oct 17, 2019
3.25 fixes:
- jboss-javassist/javassist#72
- jboss-javassist/javassist#241
- jboss-javassist/javassist#242
- jboss-javassist/javassist#246
- jboss-javassist/javassist#252
3.26 fixes:
- jboss-javassist/javassist#265
- jboss-javassist/javassist#270
- jboss-javassist/javassist#271
- jboss-javassist/javassist#275

Of these #270 is most important, as it fixes an issue we've seen
with powermock downstream.

Change-Id: Ib4d75d6411e71438436249a8eb9313ccf4411ca2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 6a404f1)
@atulrulers
Copy link

is it resolved ? Any ETA ?

@valfirst
Copy link

yes, it's fixed (I believe someone from maintainers should close it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants