New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDK11: Add support for the CONSTANT_Dynamic 17 constant introduced in Java 11 #270
Comments
OK, I'll work on this. |
I've got it implemented locally. I can submit a PR. I'm still working on the unit test but I could submit what I have. |
I don't have permission to submit a PR but would be happy to if you are interested. |
I think anyone can submit a pull request. They are not allowed to merge it, though. |
Yes. It was a issue with the macos and SSH keys. Created PR #272 |
Is there any update on the addition of Constant_Dynamic to Javassist? |
发自我的iPhone
…------------------ Original ------------------
From: richbolen <notifications@github.com>
Date: Tue,Aug 20,2019 11:02 PM
To: jboss-javassist/javassist <javassist@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Subject: Re: [jboss-javassist/javassist] JDK11: Add support for the CONSTANT_Dynamic 17 constant introduced in Java 11 (#270)
Yes. It was a issue with the macos and SSH keys. Created PR #272
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
从QQ邮箱发来的超大附件
试音.zip (8.6M, 无限期) 进入下载页面:https://wx.mail.qq.com/ftn/download?func=3&key=9a9c6363d1f56e1da8ef1663316130315ffcba6333613031404c5d0001035257525a15565059021c510208541e5803055d4e0e570007000707510e5a52563a318dccad8aacd21e4b0c132cc6b769a5820e5d8f520a8eecfa3f80c7a1bd6e69&code=ec8c3a01&k=9a9c6363d1f56e1da8ef1663316130315ffcba6333613031404c5d0001035257525a15565059021c510208541e5803055d4e0e570007000707510e5a52563a318dccad8aacd21e4b0c132cc6b769a5820e5d8f520a8eecfa3f80c7a1bd6e69
|
@chibash are there any plans to release a new version with this feature? |
I've just released. It'll be available from maven within several days. |
3.25 fixes: - jboss-javassist/javassist#72 - jboss-javassist/javassist#241 - jboss-javassist/javassist#242 - jboss-javassist/javassist#246 - jboss-javassist/javassist#252 3.26 fixes: - jboss-javassist/javassist#265 - jboss-javassist/javassist#270 - jboss-javassist/javassist#271 - jboss-javassist/javassist#275 Of these #270 is most important, as it fixes an issue we've seen with powermock downstream. Change-Id: Ib4d75d6411e71438436249a8eb9313ccf4411ca2 Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3.25 fixes: - jboss-javassist/javassist#72 - jboss-javassist/javassist#241 - jboss-javassist/javassist#242 - jboss-javassist/javassist#246 - jboss-javassist/javassist#252 3.26 fixes: - jboss-javassist/javassist#265 - jboss-javassist/javassist#270 - jboss-javassist/javassist#271 - jboss-javassist/javassist#275 Of these #270 is most important, as it fixes an issue we've seen with powermock downstream. Change-Id: Ib4d75d6411e71438436249a8eb9313ccf4411ca2 Signed-off-by: Robert Varga <robert.varga@pantheon.tech> (cherry picked from commit 6a404f1)
3.25 fixes: - jboss-javassist/javassist#72 - jboss-javassist/javassist#241 - jboss-javassist/javassist#242 - jboss-javassist/javassist#246 - jboss-javassist/javassist#252 3.26 fixes: - jboss-javassist/javassist#265 - jboss-javassist/javassist#270 - jboss-javassist/javassist#271 - jboss-javassist/javassist#275 Of these #270 is most important, as it fixes an issue we've seen with powermock downstream. Change-Id: Ib4d75d6411e71438436249a8eb9313ccf4411ca2 Signed-off-by: Robert Varga <robert.varga@pantheon.tech> (cherry picked from commit 6a404f1)
is it resolved ? Any ETA ? |
yes, it's fixed (I believe someone from maintainers should close it) |
Java 11 introduced a new constant called Constant_Dynamic (defined here https://docs.oracle.com/javase/specs/jvms/se11/html/jvms-4.html#jvms-4.4-210). When running junit tests using powermock on the Java 11 I get this error: invalid constant type: 17 at 130. Support for this constant needs to be added to the ConstPool class.
The text was updated successfully, but these errors were encountered: