Skip to content

Commit

Permalink
Add version ceiling for pypsrp (ansible#83122)
Browse files Browse the repository at this point in the history
* Add version ceiling for pypsrp

Add a version ceiling for the pypsrp requirements. This ensures that the
future v1.0.0 release won't impact existing users who install the
library using the version range specified.

* Use constraints file

* Add changelog for this change

(cherry picked from commit 2ed6c30)
  • Loading branch information
jborean93 committed Apr 30, 2024
1 parent 42baf82 commit ed97719
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 1 deletion.
2 changes: 2 additions & 0 deletions changelogs/fragments/psrp-version-req.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
bugfixes:
- Add a version ceiling constraint for pypsrp to avoid potential breaking changes in the 1.0.0 release.
2 changes: 1 addition & 1 deletion lib/ansible/plugins/connection/psrp.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
underlying transport but instead runs in a PowerShell interpreter.
version_added: "2.7"
requirements:
- pypsrp>=0.4.0 (Python library)
- pypsrp>=0.4.0, <1.0.0 (Python library)
extends_documentation_fragment:
- connection_pipelining
options:
Expand Down
1 change: 1 addition & 0 deletions test/lib/ansible_test/_data/requirements/constraints.txt
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# do not add a cryptography or pyopenssl constraint to this file, they require special handling, see get_cryptography_requirements in python_requirements.py
# do not add a coverage constraint to this file, it is handled internally by ansible-test
packaging < 21.0 ; python_version < '3.6' # packaging 21.0 requires Python 3.6 or newer
pypsrp < 1.0.0 # in case the next major version is too big of a change
pywinrm >= 0.3.0 ; python_version < '3.11' # message encryption support
pywinrm >= 0.4.3 ; python_version >= '3.11' # support for Python 3.11
pytest < 5.0.0, >= 4.5.0 ; python_version == '2.7' # pytest 5.0.0 and later will no longer support python 2.7
Expand Down

0 comments on commit ed97719

Please sign in to comment.