Each matching exception handler/action is invoked at most once #767
+156
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jbogard Can you please review this PR. |
|
I made some changes to this PR to switch to pure LINQ for resolving all the distinct handlers per type |
jbogard
approved these changes
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently base exception handlers/actions will be executed multiple times when a derived exception is thrown.
For example you have
MyExceptionHandler:IRequestExceptionHandler<MyRequest, MyResponse>, it will be invoked twice whenMyException:Exceptionis thrown. Its invocation count grows with the exception inheritance.This PR fixes this bug by checking handler/action type, please note that checking interface types is not enough because different interfaces can share the same handler/action type.