Contributing and CI Improvements #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2bndy5
force-pushed
the
contributing-ci-improvements
branch
from
0015fee
to
f532418
Compare
|
The contributing guidelines look good. As for the CI changes --- caching, via the github actions cache, is a bit tricky, because we need a key that will change if the set of fonts to be downloaded will change. It is not clear what we would hash to obtain such a key. |
|
I just create a cache that's specific to the workflow run (and OS); it can't be re-used on a subsequent run but can be reused on re-run of failed jobs. If different fonts are specified, then I'd expect the google_fonts module to pick up on what is missing and download what it needs (even using the font cache). |
jbms
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on some discussion in #284