Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more IPLA flags, from newer libc #119

Merged
merged 2 commits into from Jan 30, 2021
Merged

Add more IPLA flags, from newer libc #119

merged 2 commits into from Jan 30, 2021

Conversation

joshtriplett
Copy link
Contributor

Update the libc dependency accordingly.

@joshtriplett joshtriplett marked this pull request as draft January 5, 2021 07:47
@joshtriplett
Copy link
Contributor Author

This is a draft, and can't be merged until libc PR rust-lang/libc#2020 is merged and released.

@joshtriplett joshtriplett marked this pull request as ready for review January 8, 2021 21:36
@joshtriplett
Copy link
Contributor Author

(force-pushed to re-run CI)

@joshtriplett joshtriplett force-pushed the ipla-flags branch 3 times, most recently from 7bf65c2 to 1299414 Compare January 8, 2021 22:14
jbaublitz
jbaublitz requested changes Jan 17, 2021
View reviewed changes
Copy link
Owner

@jbaublitz jbaublitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're going to add optional trailing commas, could you make that change for all of the relevant macros? I don't wanna be in a confusing, inconsistent in-between where some accept them and some don't.

@joshtriplett
Copy link
Contributor Author

@jbaublitz Done. I've now added trailing-comma support to all exported macros that accept comma-separated lists.

@jbaublitz jbaublitz merged commit 0061ec2 into jbaublitz:master Jan 30, 2021
@jbaublitz jbaublitz assigned jbaublitz and joshtriplett and unassigned jbaublitz Feb 11, 2021
@jbaublitz jbaublitz added this to the 0.5.3 milestone Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbaublitz jbaublitz jbaublitz approved these changes

Assignees

@joshtriplett joshtriplett

Labels
enhancement
Projects
None yet
Milestone
0.5.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joshtriplett @jbaublitz