Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ordering of format controls to preserve behavior of pip #2082

Merged
merged 4 commits into from May 2, 2024

Conversation

sethmlarson
Copy link
Contributor

@sethmlarson sethmlarson commented Apr 30, 2024

Contributor checklist
  • Included tests for the changes.
  • PR title is short, clear, and ready to be included in the user-facing changelog.
Maintainer checklist
  • Verified one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

Closes #2081

@webknjaz
Copy link
Member

@sethmlarson this looks good but could you rewrite the test to use parametrize? It seems to me that this is smashing to standalone tests into the same function which is discouraged.

@sethmlarson
Copy link
Contributor Author

Thanks for the review @webknjaz, I've restructured the test to use parametrization :)

@webknjaz
Copy link
Member

@sethmlarson could you fix the linting offenses (change lists to tuples in tests). I'll enable auto-merge, meanwhile.

@webknjaz webknjaz enabled auto-merge April 30, 2024 16:30
auto-merge was automatically disabled April 30, 2024 16:36

Head branch was pushed to by a user without write access

@sethmlarson
Copy link
Contributor Author

@webknjaz Looks like automerge gets disabled if I push, you might have to enable again.

@webknjaz
Copy link
Member

No problem! The CI run also needed approval.

@webknjaz
Copy link
Member

Looks like compatibility with Pip's main need to be fixed first, which is a blocker. I didn't realize it's not only failing in the nightly runs..

@webknjaz webknjaz added this pull request to the merge queue May 2, 2024
Merged via the queue into jazzband:main with commit ad79078 May 2, 2024
34 checks passed
@ssbarnea ssbarnea added the bug Something is not working label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output --no-binary and --only-binary options to preserve pip behavior
3 participants