Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow build deps as long as at least one setup file is in sources list. #2077

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Walter-Gates-Bose
Copy link

Resolves 2076.

Passing --build-deps-for or --all-build-deps should not emit an error as long as at least one file in the sources list is a setup file.

Using pip-compile --all-build-deps requirments.in pyproject.toml gives the error --build-deps-for and --all-build-deps can be used only with the setup.py, setup.cfg and pyproject.toml specs..

According to the help, using multiple source files is valid, so any options that apply to at least one source file should be allowed as long as that option does not cause a conflict.

Contributor checklist
  • Included tests for the changes.
  • PR title is short, clear, and ready to be included in the user-facing changelog.
Maintainer checklist
  • Verified one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

Walter-Gates-Bose and others added 2 commits April 15, 2024 18:55
Passing ``--build-deps-for`` or ``--all-build-deps`` should not emit an error as long as at least one file in the sources list is a setup file.
Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm 👎 on this one since it opens up a can of worms (#2076 (comment)) — the implication of such an interface would be that the build deps of everything listed in the requirement inputs would be collected which is simply untrue.

@webknjaz
Copy link
Member

cc @apljungquist ^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using pip-compile with --build-deps-for or --all-build-deps gives error when using multiple source files.
2 participants